8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive #1835
Conversation
…eate CDS archive Reviewed-by: iklam, ccheung
|
👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
|
@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch Waiting for review |
|
@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/approval request I would like to backport this fix because the error significantly complicates the use of static CDS in some applications with user-provided class loaders. Workarounds are complicated and not always possible. Tests passed: tier1 (via GitHub CI), runtime/cds, a minimal reproducer app described in the original bug report (locally on macos/arm64). |
|
@TimPushkin |
|
Hi @TimPushkin |
|
@GoeLin, thank you, sounds reasonable |
Fixes a error which significantly complicates the use of static CDS in some applications with user-provided class loaders (workarounds require either manually editing the generated CDS classlist which is error-prone, or switching to dynamic CDS which has its own implications, or rewriting the application which is not always possible).
The conflicts were trivial: a few neighboring methods missing from this version and not directly related to the change.
The PR depends on #1833 and #1834 though it can be rewritten not to if needed.
Testing besides the CI (performed on macos/arm64):
runtime/cds, a minimal reproducer app described in the original bug report.Progress
Integration blocker
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1835/head:pull/1835$ git checkout pull/1835Update a local copy of the PR:
$ git checkout pull/1835$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1835/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1835View PR using the GUI difftool:
$ git pr show -t 1835Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1835.diff
Using Webrev
Link to Webrev Comment